Important details for oauth2 documentation #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 4, 2021 18:55
Signed-off-by: Maximilian Weber <[email protected]>
Signed-off-by: Maximilian Weber <[email protected]>
…ors. Signed-off-by: Maximilian Weber <[email protected]>
Ocramius
requested changes
Jan 7, 2021
auth/user-differentiation.md
Outdated
| @@ -285,6 +296,8 @@ final class AuthorizationListener | |||
| public function __invoke(MvcAuthEvent $mvcAuthEvent) | |||
| { | |||
| $authorization = $mvcAuthEvent->getAuthorizationService(); | |||
|
|
|||
| $authorization->addRole('user'); | |||
There was a problem hiding this comment.
Can you add a comment on what this role may mean? (magic constants are problematic, even in examples)
There was a problem hiding this comment.
The example code fails with a fatal error about missing role "user" when executing it without adding the new role:
https://discourse.laminas.dev/t/role-user-not-found-following-authorizations-docs/1397
Adds a comment for adding user role in user-differentiation.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a hart time following the manual adding api endpoint protection.